[test] Only cleanup temp directory when running CI#26567
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
[test] Only cleanup temp directory when running CI#26567sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
cleanup_temp_directory
branch
3 times, most recently
from
945231d to
8d1c534
Compare
brendandahl
reviewed
Mar 27, 2026
This causes all kind of issues if you have more than one emscripten checkout active at a given time (which I often do these days thanks the git worktrees and AI agents). The tests themselves should never leak temp files. We even have `EMTEST_DETECT_TEMPFILE_LEAKS` (which we set during CI) that ensure this is the case. I think the parallel test runner can leak temp directories if its killed at the wrong time, but emscripten-core#25615 should help with that. See emscripten-core#25614 and emscripten-core#26110
sbc100
force-pushed
the
cleanup_temp_directory
branch
from
8d1c534 to
7eff1bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes all kind of issues if you have more than one emscripten checkout active at a given time (which I often do these days thanks the git worktrees and AI agents).
The tests themselves should never leak temp files. We even have
EMTEST_DETECT_TEMPFILE_LEAKS(which we set during CI) that ensure this is the case.I think the parallel test runner can leak temp directories if its killed at the wrong time, but #25615 should help with that.
See #25614 and #26110