Add canvas transfer API for next thread#26464
Open
stevennyman wants to merge 1 commit intoemscripten-core:mainfrom
Open
Add canvas transfer API for next thread#26464stevennyman wants to merge 1 commit intoemscripten-core:mainfrom
stevennyman wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
Author
|
Following up since it's been some time |
Member
sbc100
reviewed
Mar 27, 2026
sbc100
reviewed
Mar 27, 2026
sbc100
reviewed
Mar 27, 2026
sbc100
reviewed
Mar 27, 2026
sbc100
reviewed
Mar 27, 2026
sbc100
reviewed
Mar 27, 2026
sbc100
reviewed
Mar 27, 2026
sbc100
reviewed
Mar 27, 2026
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Seems a little clunky.. but maybe there not a more elegant way to do this?
How about providing a way to transfer canvas after thread creation?
stevennyman
force-pushed
the
std-thread-next-thread-transferred-canvases
branch
2 times, most recently
from
226f855 to
ad65e2d
Compare
sbc100
reviewed
Mar 27, 2026
sbc100
reviewed
Mar 27, 2026
sbc100
reviewed
Mar 27, 2026
sbc100
reviewed
Mar 27, 2026
Useful for thread creation APIs that do not let you pass a pthread_attr_t. Fixes emscripten-core#10307.
stevennyman
force-pushed
the
std-thread-next-thread-transferred-canvases
branch
from
ad65e2d to
8a439eb
Compare
Author
Based on #10307 (comment) it appears that it might not be straightforward to implement canvas transfer methods after thread creation unless there have been changes since that comment was made. |
stevennyman
force-pushed
the
std-thread-next-thread-transferred-canvases
branch
2 times, most recently
from
73a90db to
8a439eb
Compare
Author
|
CI failures seem to be for unused variables in parts of the codebase not modified by this PR. I'm not sure why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for thread creation APIs such as
std::threadorboost::threadthat do not let you pass apthread_attr_tand therefore cannot useemscripten_pthread_attr_settransferredcanvases()for transferring canvases. Fixes #10307.The APIs added to
<emscripten/threading.h>areemscripten_set_next_thread_transferredcanvases(const char* str)andemscripten_get_next_thread_transferredcanvases(const char** str). This PR also adds a test case and documentation.(Note: I worked with an LLM while preparing this PR and made adjustments as needed.)