Skip to content

Add WS dep to emscripten_websocket_new (fixes #26310) #26317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
floooh wants to merge 1 commit into from
+1 −0
Closed

Add WS dep to emscripten_websocket_new (fixes #26310) #26317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/libwebsocket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ var LibraryWebSocket = {
return {{{ cDefs.EMSCRIPTEN_RESULT_SUCCESS }}};
},

emscripten_websocket_new__deps: ['$WS'],
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emscripten_websocket_new only references the webSockets handle allocator (it doesn't use the WS helper object). Depending on $WS will also pull in malloc via $WS__deps, which can unnecessarily increase code size for minimal builds that only call emscripten_websocket_new. Consider changing this dependency to $webSockets (or otherwise avoid bringing in malloc) so the fix is minimal and directly matches what the function uses.

Suggested change
emscripten_websocket_new__deps: ['$WS'],
emscripten_websocket_new__deps: ['$webSockets'],

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a missing dependency edge case (calling emscripten_websocket_new without any other websocket APIs). To prevent regressions, please consider adding a focused test that only links/calls emscripten_websocket_new (e.g., compile a tiny C program with -lwebsocket and run it) and asserts it doesn't throw ReferenceError: webSockets is not defined.

Suggested change
emscripten_websocket_new__deps: ['$WS'],
emscripten_websocket_new__deps: ['$WS', '$webSockets'],

Copilot uses AI. Check for mistakes.
emscripten_websocket_new__proxy: 'sync',
emscripten_websocket_new: (createAttributes) => {
if (!globalThis.WebSocket) {
Expand Down