Skip to content

mise shell detection bug when using nushell#1257

Merged
lukaszsamson merged 1 commit intoelixir-lsp:masterfrom
fedoracoreuser:feature/bug-in-shell-detection
Mar 3, 2026
Merged

mise shell detection bug when using nushell#1257
lukaszsamson merged 1 commit intoelixir-lsp:masterfrom
fedoracoreuser:feature/bug-in-shell-detection

Conversation

@fedoracoreuser
Copy link
Contributor

@fedoracoreuser fedoracoreuser commented Mar 3, 2026

This pull request updates the way the mise environment is activated in the scripts/launch.sh script to improve compatibility with different shells. The main change is a fallback mechanism that ensures mise env is invoked with a supported shell, defaulting to bash when the preferred shell is not supported.

Shell compatibility improvements:

  • scripts/launch.sh: Added a conditional to check if the preferred_shell is supported by mise env, and fall back to bash if not, ensuring reliable activation across various shell environments.

@lukaszsamson lukaszsamson merged commit 1fcc2fe into elixir-lsp:master Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants