Skip to content

docs(tutorials): update crypt4GH to proTES guide#36

Open
vschnei wants to merge 1 commit intomainfrom
crypt4gh_comments
Open

docs(tutorials): update crypt4GH to proTES guide#36
vschnei wants to merge 1 commit intomainfrom
crypt4gh_comments

Conversation

@vschnei
Copy link
Copy Markdown

@vschnei vschnei commented Apr 24, 2026

This PR updates the crypt4GH to proTES tutorial guide with important clarifications and branch information for users following the guide.

Changes Made:

  • Added a comment explaining how to use a while loop if the Funnel worker terminates after one task execution.

  • Added two notes which branches to use during deployment

Summary by Sourcery

Clarify the crypt4gh_to_protes tutorial with additional guidance for running Funnel workers and specifying appropriate proTES and middleware branches during deployment.

Documentation:

  • Document how to keep the Funnel worker running continuously using a while loop when it stops after a single task.
  • Clarify which proTES and middleware branches to use during deployment when the relevant changes are not yet merged.

Signed-off-by: Valentin Schneider-Lunitz <valentin.schneider-lunitz@charite.de>
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Apr 24, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the crypt4GH to proTES tutorial with runtime robustness guidance for Funnel workers and clarifies which branches of proTES and its Crypt4GH middleware repositories should be used when following the deployment steps.

Flow diagram for handling Funnel worker termination with while loop

flowchart TD
  A[Start Funnel worker<br/>funnel node run --config worker-config.yaml] --> B{Does worker<br/>terminate after<br/>one task?}
  B -->|No| C[Keep existing<br/>worker command]
  B -->|Yes| D[Wrap command in while loop<br/>while true; do<br/>  funnel node run --config worker-config.yaml<br/>done]
  C --> E[Continue tutorial]
  D --> E
Loading

File-Level Changes

Change Details Files
Documented how to keep the Funnel worker running continuously if it exits after a single task.
  • Added an inline comment in the Funnel setup section explaining that the worker command can be wrapped in a while loop if the worker terminates after executing one task.
  • Provided a commented example of a bash while loop that continuously restarts funnel node run --config worker-config.yaml.
docs/tutorials/crypt4gh_to_protes.md
Clarified which Git branches to use for proTES and its Crypt4GH middleware when following the installation instructions.
  • Updated the proTES installation instruction to recommend using the adjust_middleware branch if the relevant changes are not yet merged into the default branch.
  • Updated the middleware installation reference to recommend using the update_middleware branch of the protes-middleware-crypt4gh repository if not yet merged.
docs/tutorials/crypt4gh_to_protes.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@vschnei vschnei requested a review from Copilot April 24, 2026 08:46
@vschnei vschnei self-assigned this Apr 24, 2026
@vschnei vschnei requested a review from svedziok April 24, 2026 08:47
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider clarifying under what exact conditions the Funnel worker terminates and when the while-loop workaround is needed, so users understand why they might need this rather than blindly copying it.
  • Instead of embedding specific branch names in the prose, you might want to phrase the instructions so they remain valid after the branches are merged (e.g., note that users should check if the feature is available on the default branch and otherwise use the given branch).
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider clarifying under what exact conditions the Funnel worker terminates and when the while-loop workaround is needed, so users understand why they might need this rather than blindly copying it.
- Instead of embedding specific branch names in the prose, you might want to phrase the instructions so they remain valid after the branches are merged (e.g., note that users should check if the feature is available on the default branch and otherwise use the given branch).

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Crypt4GH → proTES tutorial to reduce user confusion during deployment by adding worker-runtime guidance and specifying which branches to use when upstream changes aren’t merged yet.

Changes:

  • Add guidance for keeping a Funnel worker running continuously (while-loop suggestion).
  • Clarify which proTES and protes-middleware-crypt4gh branches to deploy when required changes are unmerged.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +172 to 175
# If worker terminates after one task execution, put the command in a while loop.
# while true; do funnel node run --config worker-config.yaml; done
funnel node run --config worker-config.yaml &
```
Comment on lines +181 to +183
ProTES acts as a gateway and provides middleware for automatic Crypt4GH decryption. Follow the [proTES](https://github.com/elixir-cloud-aai/proTES) (use 'adjust_middleware' branch if not yet merged) installation guide to deploy proTES on your third VM.

For detailed middleware installation, refer to the [protes-middleware-crypt4gh](https://github.com/elixir-cloud-aai/protes-middleware-crypt4gh).
For detailed middleware installation, refer to the [protes-middleware-crypt4gh](https://github.com/elixir-cloud-aai/protes-middleware-crypt4gh) (use 'update_middleware' branch if not yet merged).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants