Open
Conversation
Signed-off-by: Valentin Schneider-Lunitz <valentin.schneider-lunitz@charite.de>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the crypt4GH to proTES tutorial with runtime robustness guidance for Funnel workers and clarifies which branches of proTES and its Crypt4GH middleware repositories should be used when following the deployment steps. Flow diagram for handling Funnel worker termination with while loopflowchart TD
A[Start Funnel worker<br/>funnel node run --config worker-config.yaml] --> B{Does worker<br/>terminate after<br/>one task?}
B -->|No| C[Keep existing<br/>worker command]
B -->|Yes| D[Wrap command in while loop<br/>while true; do<br/> funnel node run --config worker-config.yaml<br/>done]
C --> E[Continue tutorial]
D --> E
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider clarifying under what exact conditions the Funnel worker terminates and when the while-loop workaround is needed, so users understand why they might need this rather than blindly copying it.
- Instead of embedding specific branch names in the prose, you might want to phrase the instructions so they remain valid after the branches are merged (e.g., note that users should check if the feature is available on the default branch and otherwise use the given branch).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider clarifying under what exact conditions the Funnel worker terminates and when the while-loop workaround is needed, so users understand why they might need this rather than blindly copying it.
- Instead of embedding specific branch names in the prose, you might want to phrase the instructions so they remain valid after the branches are merged (e.g., note that users should check if the feature is available on the default branch and otherwise use the given branch).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Crypt4GH → proTES tutorial to reduce user confusion during deployment by adding worker-runtime guidance and specifying which branches to use when upstream changes aren’t merged yet.
Changes:
- Add guidance for keeping a Funnel worker running continuously (while-loop suggestion).
- Clarify which proTES and protes-middleware-crypt4gh branches to deploy when required changes are unmerged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+172
to
175
| # If worker terminates after one task execution, put the command in a while loop. | ||
| # while true; do funnel node run --config worker-config.yaml; done | ||
| funnel node run --config worker-config.yaml & | ||
| ``` |
Comment on lines
+181
to
+183
| ProTES acts as a gateway and provides middleware for automatic Crypt4GH decryption. Follow the [proTES](https://github.com/elixir-cloud-aai/proTES) (use 'adjust_middleware' branch if not yet merged) installation guide to deploy proTES on your third VM. | ||
|
|
||
| For detailed middleware installation, refer to the [protes-middleware-crypt4gh](https://github.com/elixir-cloud-aai/protes-middleware-crypt4gh). | ||
| For detailed middleware installation, refer to the [protes-middleware-crypt4gh](https://github.com/elixir-cloud-aai/protes-middleware-crypt4gh) (use 'update_middleware' branch if not yet merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the crypt4GH to proTES tutorial guide with important clarifications and branch information for users following the guide.
Changes Made:
Added a comment explaining how to use a while loop if the Funnel worker terminates after one task execution.
Added two notes which branches to use during deployment
Summary by Sourcery
Clarify the crypt4gh_to_protes tutorial with additional guidance for running Funnel workers and specifying appropriate proTES and middleware branches during deployment.
Documentation: