-
Notifications
You must be signed in to change notification settings - Fork 1k
Support for Hungarian language #8573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for creating this PR, we are currently restructuring the frontend code a bit, but I'll bring your contributions live soon :) |
|
Sounds good, let me know if the locals template changes. |
|
Hey again, sorry for the slow feedback. Typos / spelling
Capitalization / style consistency
Untranslated / mixed-language bits
Meaning/wording improvements (optional)These aren’t wrong, just a bit unnatural:
|
Thanks for the suggestions @madsnedergaard. I will address the first three points, but I wanted to ask for some guidance on the formality aspect highlighted under the last point. In Hungarian there are two forms that you can use - informal (tegező) and formal (önöző). If I were to go to a bank or a have a doctor's appointment, I would use the formal form, whereas if I'm meeting friends or talking to colleagues of my age I would be using the informal form. The German language has these two forms (per du for informal and per Sie for formal). The current German locale is using the formal form which is what I went with, but I wanted to get your view on which one is preferred by Electricity Maps? |
|
Thanks, appreciate it! Formal sounds fine in that case :) |
|
I corrected all the issues raised, happy to proceed to the next step. |
Issue
No issue reference
Description
Added support for Hungarian language.
Preview
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.