Skip to content

Conversation

@csebe12
Copy link

@csebe12 csebe12 commented Jan 3, 2026

Issue

No issue reference

Description

Added support for Hungarian language.

Preview

Double check

  • [] I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@madsnedergaard
Copy link
Member

Thanks for creating this PR, we are currently restructuring the frontend code a bit, but I'll bring your contributions live soon :)

@csebe12
Copy link
Author

csebe12 commented Jan 9, 2026

Sounds good, let me know if the locals template changes.

@madsnedergaard
Copy link
Member

Hey again, sorry for the slow feedback.
While in the process of implementing your translations, I ran it through a quick LLM check and it flagged the following things. Would you mind addressing those and updating as appropriate where the suggestions make sense?


Typos / spelling

  • funkcionialitástfunkcionalitást

  • Az Electricity Map-ről → likely Az Electricity Maps-ről (brand consistency) and Hungarian suffix usually Electricity Mapsről (without hyphen) is also common, but “-ről” after an English name is acceptable style-wise if you standardize it.

  • Several places have missing/odd hyphenation:

    • Áramlás követésÁramláskövetés or Áramlás-követés (you use both elsewhere; pick one)
    • villamosenergia-áramlások vs Villamosenergia-áramlások casing consistency

Capitalization / style consistency

  • info.text begins with egy API-platform... → should be Egy API-platform...

  • Some titles are in Title Case in Hungarian (generally not used like in English). Example:

    • Villamos Energia Hálózat Karbonkibocsátások reads odd; more natural:

      • Villamosenergia-hálózati karbonkibocsátások or A villamosenergia-hálózat karbonkibocsátásai
  • “Facebook-on”, “LinkedIn-en”, “Reddit-en” are understandable but could be standardized (Hungarian often writes these without hyphen in casual UI, e.g. “Facebookon”), but that’s style preference.

Untranslated / mixed-language bits

  • "github": "Contribute on GitHub" is still English (maybe intentional, but inconsistent with the rest).

  • In two places you have anchor text "here" left in English:

    • dataIsEstimated ... <a ...>here</a>.
    • exchangesAreMissing ... <a ...>here</a>.
      Suggest: „itt”.
  • mobile-main-menu.map: "Electricity Maps" kept (fine as brand).

Meaning/wording improvements (optional)

These aren’t wrong, just a bit unnatural:

  • "Hagyjon visszajelzést" is polite/formal; UI often uses „Adjon visszajelzést”.

  • "Szerezd meg az appot" is informal (tegező) while much of onboarding uses formal (önöző) like “Üdvözöljük”, “Engedje meg”. You should choose one tone:

    • Formal: „Szerezze be az alkalmazást”
    • Informal: rewrite the onboarding to tegező (bigger change).
  • "Időjárási adatok nem elérhetők ebben a felbontásban": understandable, might be smoother:

    • „Időjárási adatok nem érhetők el ezen a felbontáson…”

@madsnedergaard madsnedergaard added the change requested A change was requested from the contributor label Jan 27, 2026
@csebe12
Copy link
Author

csebe12 commented Jan 28, 2026

Hey again, sorry for the slow feedback. While in the process of implementing your translations, I ran it through a quick LLM check and it flagged the following things. Would you mind addressing those and updating as appropriate where the suggestions make sense?

Typos / spelling

  • funkcionialitástfunkcionalitást

  • Az Electricity Map-ről → likely Az Electricity Maps-ről (brand consistency) and Hungarian suffix usually Electricity Mapsről (without hyphen) is also common, but “-ről” after an English name is acceptable style-wise if you standardize it.

  • Several places have missing/odd hyphenation:

    • Áramlás követésÁramláskövetés or Áramlás-követés (you use both elsewhere; pick one)
    • villamosenergia-áramlások vs Villamosenergia-áramlások casing consistency

Capitalization / style consistency

  • info.text begins with egy API-platform... → should be Egy API-platform...

  • Some titles are in Title Case in Hungarian (generally not used like in English). Example:

    • Villamos Energia Hálózat Karbonkibocsátások reads odd; more natural:

      • Villamosenergia-hálózati karbonkibocsátások or A villamosenergia-hálózat karbonkibocsátásai
  • “Facebook-on”, “LinkedIn-en”, “Reddit-en” are understandable but could be standardized (Hungarian often writes these without hyphen in casual UI, e.g. “Facebookon”), but that’s style preference.

Untranslated / mixed-language bits

  • "github": "Contribute on GitHub" is still English (maybe intentional, but inconsistent with the rest).

  • In two places you have anchor text "here" left in English:

    • dataIsEstimated ... <a ...>here</a>.
    • exchangesAreMissing ... <a ...>here</a>.
      Suggest: „itt”.
  • mobile-main-menu.map: "Electricity Maps" kept (fine as brand).

Meaning/wording improvements (optional)

These aren’t wrong, just a bit unnatural:

  • "Hagyjon visszajelzést" is polite/formal; UI often uses „Adjon visszajelzést”.

  • "Szerezd meg az appot" is informal (tegező) while much of onboarding uses formal (önöző) like “Üdvözöljük”, “Engedje meg”. You should choose one tone:

    • Formal: „Szerezze be az alkalmazást”
    • Informal: rewrite the onboarding to tegező (bigger change).
  • "Időjárási adatok nem elérhetők ebben a felbontásban": understandable, might be smoother:

    • „Időjárási adatok nem érhetők el ezen a felbontáson…”

Thanks for the suggestions @madsnedergaard. I will address the first three points, but I wanted to ask for some guidance on the formality aspect highlighted under the last point.

In Hungarian there are two forms that you can use - informal (tegező) and formal (önöző). If I were to go to a bank or a have a doctor's appointment, I would use the formal form, whereas if I'm meeting friends or talking to colleagues of my age I would be using the informal form.

The German language has these two forms (per du for informal and per Sie for formal). The current German locale is using the formal form which is what I went with, but I wanted to get your view on which one is preferred by Electricity Maps?

Copy link
Member

Thanks, appreciate it! Formal sounds fine in that case :)

@csebe12
Copy link
Author

csebe12 commented Jan 28, 2026

I corrected all the issues raised, happy to proceed to the next step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change requested A change was requested from the contributor Frontend 🎨

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants