[WIP]fix: revert invalid [with(...)] collection syntax #3366
Closed
groman92 wants to merge 4 commits into
Closed
Conversation
groman92
had a problem deploying
to
integration-tests
GitHub Actions
Failure
|
Label error. Requires exactly 1 of: automation, breaking, bug, changelog:skip, chore, ci, dependencies, documentation, enhancement, feature, fix, redesign. Found: build |
groman92
changed the title
groman92
had a problem deploying
to
integration-tests
GitHub Actions
Failure
groman92
had a problem deploying
to
integration-tests
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NEED to investigate this.
Commit ("Fix new SDK Warnings") introduced [with(...)] as a syntax for creating collections with a custom comparer:
// What was introduced (not valid C#)
private readonly Dictionary<string, string> _substitutions = [with(StringComparer.OrdinalIgnoreCase)];
// What it should be
private readonly Dictionary<string, string> _substitutions = new(StringComparer.OrdinalIgnoreCase);
[with(...)] is not valid in any released C# version, including the C# 14 preview shipping with .NET 10. Inside a collection expression [...], with is treated as an identifier name — not a keyword — causing CS0103: The name 'with' does not exist in the current context. This broke the build for anyone pulling main after that commit.