refactor(admin-api): validate dep aliases at handler edge#1875
Merged
Conversation
Move dependency alias checks from catalog creation (where missing aliases panicked or returned deep errors) to the handler layer, enforcing the validate-at-the-edge principle. - Check table and function dep aliases in `common.rs` and `schema.rs` before catalog creation - Replace `DependencyAliasNotFound` error variants in catalog modules with `expect()` panics guarded by precondition docs - Inline `DependencyAliasNotFound` fields into `ManifestValidationError` and schema `Error` - Add integration test for missing function dependency alias Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
Contributor
Author
|
This is a spinoff of #1849 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move dependency alias checks from catalog creation (where missing aliases panicked or returned deep errors) to the handler layer, enforcing the validate-at-the-edge principle.
common.rsandschema.rsbefore catalog creationDependencyAliasNotFounderror variants in catalog modules withexpect()panics guarded by precondition docsDependencyAliasNotFoundfields intoManifestValidationErrorand schemaError