feat(data-store): add namespace prefix to object storage paths#1798
Merged
shiyasmohd merged 1 commit intomainfrom Feb 25, 2026
Merged
feat(data-store): add namespace prefix to object storage paths#1798shiyasmohd merged 1 commit intomainfrom
shiyasmohd merged 1 commit intomainfrom
Conversation
shiyasmohd
force-pushed
the
shiyasmohd/namespace-in-path
branch
from
24b18eb to
ae512ec
Compare
shiyasmohd
force-pushed
the
shiyasmohd/namespace-in-path
branch
4 times, most recently
from
1e40425 to
899495e
Compare
LNSD
requested changes
Feb 24, 2026
Contributor
LNSD
left a comment
LNSD
left a comment
There was a problem hiding this comment.
The legacy flag should be removed from this PR. The restore_latest_table_revision method should always use the new namespaced path (PhyTablePath::new with namespace). The use case it covers (restoring data written under the old path layout without the namespace prefix) is already covered by the restore with "custom path" revision flow.
The rest of the PR (adding namespace to the storage path for writes via PhyTableRevisionPath::new and PhyTablePath::new) is ok.
shiyasmohd
force-pushed
the
shiyasmohd/namespace-in-path
branch
from
899495e to
d5ffbd3
Compare
shiyasmohd
force-pushed
the
shiyasmohd/namespace-in-path
branch
from
d5ffbd3 to
7b1c51e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PhyTablePath,PhyTableRevisionPath, andPhyTableUrlformats