Skip to content

Comments

refactor(ampd): standardize env var names with AMP_prefix#1702

Open
mitchhs12 wants to merge 1 commit intomainfrom
standardize-ampd-env-vars
Open

refactor(ampd): standardize env var names with AMP_prefix#1702
mitchhs12 wants to merge 1 commit intomainfrom
standardize-ampd-env-vars

Conversation

@mitchhs12
Copy link
Contributor

@mitchhs12 mitchhs12 commented Feb 5, 2026

Standardize environment variable names under the AMP_ namespace and rewrite subcommand help text with precise behavioral descriptions.

  • Rename FLIGHT_SERVER, JSONL_SERVER, ADMIN_SERVER to AMP_FLIGHT_SERVER, AMP_JSONL_SERVER, AMP_ADMIN_SERVER in solo/server subcommands
  • Remove GM_* env var bindings from ampctl generate (CLI-only flags)
  • Rewrite clap doc comments with port numbers, behavioral notes, and endpoint-selection semantics
  • Update feature docs with configuration tables, env var references, and status frontmatter

Note

Low Risk
Primarily CLI/env-var surface-area and documentation changes; runtime behavior is largely preserved via backward-compatible env var handling, with limited risk of misconfiguration during the transition.

Overview
Standardizes ampd CLI environment variables for endpoint selection by renaming FLIGHT_SERVER/JSONL_SERVER/ADMIN_SERVER to AMP_FLIGHT_SERVER/AMP_JSONL_SERVER/AMP_ADMIN_SERVER, while adding backward-compat checks that honor the old names with deprecation warnings.

Removes all GM_* environment-variable bindings from ampctl manifest generate, making those parameters strictly CLI flags. Updates CLI help text and feature documentation to reflect the new env var names, clarify endpoint-selection behavior (including ports), and adds/marks feature docs as stable (including a new app-ampd-migrate doc).

Written by Cursor Bugbot for commit 00784ae. This will update automatically on new commits. Configure here.

@mitchhs12 mitchhs12 self-assigned this Feb 5, 2026
@mitchhs12
Copy link
Contributor Author

Not sure whether the deprecation notice for this should be in the upgrading.md file.

How long should we keep this in here?

@mitchhs12 mitchhs12 requested review from LNSD and shiyasmohd February 5, 2026 18:38
@LNSD LNSD assigned LNSD and unassigned mitchhs12 Feb 20, 2026
@LNSD
Copy link
Contributor

LNSD commented Feb 20, 2026

@mitchhs12 I am taking over this PR

@LNSD LNSD force-pushed the standardize-ampd-env-vars branch from d2b63ee to 8590030 Compare February 21, 2026 13:36
Support deprecated env var names (FLIGHT_SERVER, JSONL_SERVER,
ADMIN_SERVER) with runtime deprecation warnings to stderr.
@LNSD LNSD force-pushed the standardize-ampd-env-vars branch from 8590030 to 00784ae Compare February 21, 2026 13:53
@LNSD LNSD requested review from LNSD and removed request for LNSD February 21, 2026 13:58
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants