refactor(ampd): standardize env var names with AMP_prefix#1702
Open
refactor(ampd): standardize env var names with AMP_prefix#1702
Conversation
Contributor
Author
|
Not sure whether the deprecation notice for this should be in the How long should we keep this in here? |
LNSD
reviewed
Feb 5, 2026
LNSD
reviewed
Feb 5, 2026
Contributor
|
@mitchhs12 I am taking over this PR |
d2b63ee to
8590030
Compare
Support deprecated env var names (FLIGHT_SERVER, JSONL_SERVER, ADMIN_SERVER) with runtime deprecation warnings to stderr.
8590030 to
00784ae
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize environment variable names under the AMP_ namespace and rewrite subcommand help text with precise behavioral descriptions.
FLIGHT_SERVER,JSONL_SERVER,ADMIN_SERVERtoAMP_FLIGHT_SERVER,AMP_JSONL_SERVER,AMP_ADMIN_SERVERin solo/server subcommandsGM_*env var bindings fromampctlgenerate (CLI-only flags)Note
Low Risk
Primarily CLI/env-var surface-area and documentation changes; runtime behavior is largely preserved via backward-compatible env var handling, with limited risk of misconfiguration during the transition.
Overview
Standardizes
ampdCLI environment variables for endpoint selection by renamingFLIGHT_SERVER/JSONL_SERVER/ADMIN_SERVERtoAMP_FLIGHT_SERVER/AMP_JSONL_SERVER/AMP_ADMIN_SERVER, while adding backward-compat checks that honor the old names with deprecation warnings.Removes all
GM_*environment-variable bindings fromampctl manifest generate, making those parameters strictly CLI flags. Updates CLI help text and feature documentation to reflect the new env var names, clarify endpoint-selection behavior (including ports), and adds/marks feature docs as stable (including a newapp-ampd-migratedoc).Written by Cursor Bugbot for commit 00784ae. This will update automatically on new commits. Configure here.