Skip to content

Angular Material: Remove EnumOption[] type from AutocompleteControlRenderer.options #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-shuy wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −22
Open

Angular Material: Remove EnumOption[] type from AutocompleteControlRenderer.options #2550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 7 additions & 22 deletions packages/angular-material/src/library/controls/autocomplete.renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export class AutocompleteControlRenderer
extends JsonFormsControl
implements OnInit
{
@Input() options?: EnumOption[] | string[];
@Input() options?: string[];
valuesToTranslatedOptions?: Map<string, EnumOption>;
filteredOptions: Observable<EnumOption[]>;
shouldFilter: boolean;
Expand Down Expand Up @@ -209,29 +209,14 @@ export class AutocompleteControlRenderer
protected getOwnProps(): OwnPropsOfControl & OwnPropsOfEnum {
return {
...super.getOwnProps(),
options: this.stringOptionsToEnumOptions(this.options),
options: this.options?.map((str) => {
return {
label: str,
value: str,
} satisfies EnumOption;
}),
};
}

/**
* For {@link options} input backwards compatibility
*/
protected stringOptionsToEnumOptions(
options: typeof this.options
): EnumOption[] | undefined {
if (!options) {
return undefined;
}

return options.every((item) => typeof item === 'string')
? options.map((str) => {
return {
label: str,
value: str,
} satisfies EnumOption;
})
: options;
}
}

export const enumControlTester: RankedTester = rankWith(2, isEnumControl);