Remove unwanted inner try block#2741
Open
SougandhS wants to merge 1 commit into
Open
Conversation
Contributor
merks
reviewed
Jun 7, 2026
| } | ||
| } catch (Exception e) { | ||
| DebugPlugin.log(e); | ||
| if (attr.startsWith(MULTI_LAUNCH_CONSTANTS_PREFIX)) { |
Contributor
There was a problem hiding this comment.
What kind of exception might happen? Do you really want the whole loop to terminate if there is an exception?
Contributor
Author
There was a problem hiding this comment.
Since neither startsWith() nor removeAttribute() declares any exceptions, I initially thought the inner try/catch could be removed
Contributor
There was a problem hiding this comment.
It all looks a little overly cautious given that nothing declares any thrown exceptions. It looks like it's always been there so there's no real accounting for why either of those try blocks are there, neither the inner nor the outer. Maybe it happened during some initial implementation and was then never cleaned up. I'm not sure what to say about that. 😞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.