Skip to content

Properly register ConsoleManager listeners on workbench windows #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iloveeclipse merged 1 commit into from
Feb 16, 2026
Merged

Properly register ConsoleManager listeners on workbench windows #2456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions ...rg.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/internal/ConsoleManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import org.eclipse.ui.IWorkbenchPage;
import org.eclipse.ui.IWorkbenchPart;
import org.eclipse.ui.IWorkbenchPartReference;
import org.eclipse.ui.IWorkbenchWindow;
import org.eclipse.ui.PartInitException;
import org.eclipse.ui.PerspectiveAdapter;
import org.eclipse.ui.PlatformUI;
Expand Down Expand Up @@ -156,16 +157,24 @@ public void partInputChanged(IWorkbenchPartReference partRef) {
public ConsoleManager() {
perspectiveListener = new ConsoleManagerPerspectiveListener();
partListener = new ConsoleManagerPartListener();
}

if (PlatformUI.isWorkbenchRunning() && PlatformUI.getWorkbench() != null
&& PlatformUI.getWorkbench().getActiveWorkbenchWindow() != null) {
PlatformUI.getWorkbench().getActiveWorkbenchWindow().addPerspectiveListener(perspectiveListener);

IPartService service = PlatformUI.getWorkbench().getActiveWorkbenchWindow().getPartService();
public void addWindowAndPerspectiveListeners(IWorkbenchWindow window) {
if (PlatformUI.isWorkbenchRunning() && window != null) {
window.addPerspectiveListener(perspectiveListener);
IPartService service = window.getPartService();
service.addPartListener(partListener);
}
}

public void removeWindowAndPerspectiveListeners(IWorkbenchWindow window) {
if (PlatformUI.isWorkbenchRunning() && window != null) {
window.removePerspectiveListener(perspectiveListener);
IPartService service = window.getPartService();
service.removePartListener(partListener);
}
}

/**
* Returns the active workbench window page if the workbench is still running.
*
Expand Down
6 changes: 6 additions & 0 deletions ...l.view.ui/src/org/eclipse/terminal/view/ui/internal/listeners/AbstractWindowListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
*******************************************************************************/
package org.eclipse.terminal.view.ui.internal.listeners;

import org.eclipse.terminal.view.ui.internal.ConsoleManager;
import org.eclipse.terminal.view.ui.launcher.ITerminalConsoleViewManager;
import org.eclipse.ui.IPartListener2;
import org.eclipse.ui.IPartService;
import org.eclipse.ui.IPerspectiveListener;
Expand Down Expand Up @@ -85,6 +87,8 @@ public void windowClosed(IWorkbenchWindow window) {
if (perspectiveListener != null) {
window.removePerspectiveListener(perspectiveListener);
}
ConsoleManager consoleViewManager = (ConsoleManager) window.getService(ITerminalConsoleViewManager.class);
consoleViewManager.removeWindowAndPerspectiveListeners(window);
}
}

Expand Down Expand Up @@ -119,6 +123,8 @@ public void windowOpened(IWorkbenchWindow window) {
}
}

ConsoleManager consoleViewManager = (ConsoleManager) window.getService(ITerminalConsoleViewManager.class);
consoleViewManager.addWindowAndPerspectiveListeners(window);
initialized = true;
}
}
Expand Down
Loading