Make unsaved changes indicator the default on tabs#4070
Merged
Conversation
Contributor
vogella
force-pushed
the
dirty-indicator-default
branch
from
3ad33ec to
9193f33
Compare
Flip SHOW_DIRTY_INDICATOR_ON_TABS_DEFAULT to true so the dirty indicator introduced in 4.40 becomes opt-out, gathering broader feedback during this development cycle.
vogella
force-pushed
the
dirty-indicator-default
branch
from
9193f33 to
f28cc44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the new unsaved-changes (dirty) indicator on view and editor tabs the default by flipping
SHOW_DIRTY_INDICATOR_ON_TABS_DEFAULTtotrue.The indicator was introduced as opt-in in 4.40 and was generally well received.
Making it opt-out during this development cycle means developers and users exercise it by default and can give feedback, while anyone who prefers the old close-button behavior can still disable it on the Appearance preference page.
If it does not prove mature enough we can easily revert to opt-in before release.
Implements #4045