Adjust wait for initial dialog contents in QuickAccessDialogTest#4027
Merged
Conversation
Contributor
|
Feel free to merge changes intended to fix/improve flaky tests. |
Contributor
Author
|
Alright, though I have doubts this will help. I still see async code running despite the change, just less of it. The code in the job done listener is proving difficult to wait for... If that is even the cause for the I-build fails. So no rush from my side to merge this. |
Contributor
trancexpress
force-pushed
the
gh4009
branch
2 times, most recently
from
ba93dca to
126eaf5
Compare
…g outputs Adjusted the wait for initial dialog contents in QuickAccessDialogTest.testPreviousChoicesAvailableForExtension(), to rely on QuickAccessDialog.setInfoText() instead of relying on specific dialog contents set during the test. Additionally debug outputs are added when setting dialog contents, the debug outputs are enabled for QuickAccessDialogTest. See: eclipse-platform#4009
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted the wait for initial dialog contents in
QuickAccessDialogTest.testPreviousChoicesAvailableForExtension(), to rely onQuickAccessDialog.setInfoText()instead of relying on specific dialog contents set during the test.See: #4009