Refactor: Improve refresh action performance with parallel processing#3576
Draft
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
Draft
Refactor: Improve refresh action performance with parallel processing#3576vogella wants to merge 2 commits intoeclipse-platform:masterfrom
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
Conversation
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
iloveeclipse
requested changes
Dec 12, 2025
Member
iloveeclipse
left a comment
iloveeclipse
left a comment
There was a problem hiding this comment.
The original code was executed as WorkspaceModifyOperation with a rule, not it seem that you explicitly allows multiple threads to run multiple workspace related tasks without holding any rule.
Even as a draft, this makes no sense.
Contributor
I was about to post the same comment for the same reason. |
Previously a single WorkspaceJob was scheduled with a combined MultiRule across all selected projects. This still refreshed all resources sequentially and held every project lock simultaneously, which was more restrictive than needed. Now RefreshAction.run() groups resources by their scheduling rule (project or workspace root) and calls scheduleRefreshJob() once per group. Each group gets its own WorkspaceModifyOperation protected by only that project's rule, so independent projects can be refreshed in parallel while concurrent workspace access to a single project is still prevented. Two new protected hook methods are added to RefreshAction: - createRefreshJob(): builds the WorkspaceModifyOperation-wrapped WorkspaceJob without scheduling it, so callers can attach IJobChangeListeners before scheduling (no race condition). - scheduleRefreshJob(): default implementation calls createRefreshJob().schedule(); subclasses override to customise. ResourceMgmtActionProvider no longer duplicates the run() logic. It overrides scheduleRefreshJob() instead, attaches a JobChangeAdapter that triggers a Navigator viewer refresh after each project's job completes, then schedules the job. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vogella
force-pushed
the
parallel-refresh
branch
from
02f095d to
ccda0fc
Compare
Member
|
Workspace operations in general can't be parallelized, there is always a central workspace lock anyway. |
When multiple projects are refreshed simultaneously, the Progress view previously showed identical "refresh" entries for every job. Each job now uses "refresh (ProjectName)" so users can see which project is being refreshed. Jobs covering the workspace root retain the plain "refresh" title. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
The WorkspaceJob Javadoc says the opposite : // org.eclipse.core.resources/WorkspaceJob.java (Starting line 47) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced WorkspaceModifyOperation with IRunnableWithProgress and direct Job usage in RefreshAction and ResourceMgmtActionProvider to enable parallel refreshing of resources and improve performance.