Skip to content

Remove obsolete and misleading code comment #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeikoKlare merged 1 commit into from
Jun 6, 2026
+0 −5
Merged

Remove obsolete and misleading code comment #3367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Button.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,11 +206,6 @@ void _setText (String text) {
OS.SetWindowLong (handle, OS.GWL_STYLE, newBits);
OS.InvalidateRect (handle, null, true);
}
/*
* Bug in Windows. When a Button control is right-to-left and
* is disabled, the first pixel of the text is clipped. The fix
* is to append a space to the text.
*/
TCHAR buffer = new TCHAR (getCodePage (), text, true);
OS.SetWindowText (handle, buffer);
if ((state & HAS_AUTO_DIRECTION) != 0) {
Expand Down
Loading