[Win32] Suppress deprecation warnings in IE implementation#3361
Open
HeikoKlare wants to merge 1 commit into
Open
[Win32] Suppress deprecation warnings in IE implementation#3361HeikoKlare wants to merge 1 commit into
HeikoKlare wants to merge 1 commit into
Conversation
The IE implementation uses deprecated methods from OleClientSite for removing event listener. There does not seem to be any intent in actually removing that method. Since IE is EOL, there is no need to updating that code to something else either. Thus, this silences the internal deprecation warnings as it does not provide any useful information.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IE implementation uses deprecated methods from OleClientSite for removing event listener. There does not seem to be any intent in actually removing that method. Since IE is EOL, there is no need to updating that code to something else either. Thus, this silences the internal deprecation warnings as it does not provide any useful information.