[Gtk4] Fix Browser.setText#3098
Conversation
|
This is purely Gtk 4 change so should be safe to get into RC2. @HeikoKlare , @merks , @iloveeclipse - could someone approve ? |
|
It looks fine to me. @HeikoKlare can approve as a PL. |
bundles/org.eclipse.swt/Eclipse SWT WebKit/gtk/org/eclipse/swt/browser/WebKit.java
Show resolved
Hide resolved
|
I have no objections to merge that, but I would wish a bit more comments in the code explaining the different modes and why the different modes used for which GTK version. |
Disable hardware-acceleration-policy on Gtk 4.x (it is done for Gtk 3.x already) as first frame is never drawn when using accelerated compositing (GPU path). The DOM loads, signals fire, but the view stays blank. Different value compared to Gtk 3 is due to the fact that the setting no longer has always/ondemand/never but just always/never on Gtk 4.
iloveeclipse
left a comment
iloveeclipse
left a comment
There was a problem hiding this comment.
OMG, why should such trivial values like "never" change in different versions?
It's enum on C side (https://github.com/WebKit/WebKit/blob/3af87ab356f096e67488c2e992e06cf729f9f702/Source/WebKit/UIProcess/API/glib/WebKitSettings.h.in#L85 ) thus safe but SWT uses just the "ordinal" as we can't ifdef and having multiple enums for same purpose but different versions would make things even worse. |
3 participants
Disable hardware-acceleration-policy on Gtk 4.x (it is done for Gtk 3.x already) as first frame is never drawn when using accelerated compositing (GPU path). The DOM loads, signals fire, but the view stays blank.
Different value compared to Gtk 3 is due to the fact that the setting no longer has always/ondemand/never but just always/never on Gtk 4.