fix: Add missing workspaces-config label to vscode-editor-configurations ConfigMap#3072
Open
snecklifter wants to merge 1 commit intoeclipse-che:mainfrom
Open
Conversation
…ons ConfigMap The vscode-editor-configurations ConfigMap example was missing the app.kubernetes.io/component: workspaces-config label. Without this label, the ConfigMap does not propagate correctly to user namespaces, preventing the editor configurations from being applied across workspaces. This change adds the missing label to align with other ConfigMap examples in the documentation (manage-extension-installation.adoc and configuring-a-user-namespace.adoc). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
snecklifter
requested review from
a team,
deerskindoll,
gtrivedi88 and
mkuznyetsov
as code owners
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
|
⚡️ Deploying pull request preview... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
Adds the missing
app.kubernetes.io/component: workspaces-configlabel to thevscode-editor-configurationsConfigMap example in the editor-configurations-for-microsoft-visual-studio-code.adoc file.What issues does this pull request fix or reference?
This fixes an inconsistency in the documentation where the ConfigMap example was missing a required label. Without the
app.kubernetes.io/component: workspaces-configlabel, the ConfigMap does not propagate correctly to user namespaces, preventing the editor configurations from being applied across workspaces.Specify the version of the product this pull request applies to
This applies to the main branch (next version).
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.