Conversation
olexii4
requested review from
a team,
deerskindoll,
gtrivedi88 and
mkuznyetsov
as code owners
|
🎊 Navigate the preview: https://69e0e378779e5711d117c758--eclipse-che-docs-pr.netlify.app 🎊 |
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
Rename and expand the ConsoleLink icon page to cover all branding images under assets/branding with supported formats (jpg, jpeg, png, gif, webp, svg). Add favicon.ico override. Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>
svor
reviewed
Apr 15, 2026
| <1> The loader image file name and Base64-encoded content with disabled line wrapping. You can use any supported format (`jpg`, `jpeg`, `png`, `gif`, `webp`, `svg`). For example, `loader.png` with its Base64-encoded content. | ||
| <2> The favicon file name and Base64-encoded content with disabled line wrapping. | ||
| + | ||
| NOTE: You can override one or all images from the `/public/dashboard/assets/branding` directory. Only the images specified in the Secret `data` section are overridden; unspecified images remain unchanged. |
Contributor
There was a problem hiding this comment.
not clear where /public/dashboard/assets/branding is located, need to document that it's from dashboard pod
| [id="customizing-openshift-che-branding-images"] | ||
| = Customizing {ocp} {prod} branding images | ||
|
|
||
| This procedure describes how to customize {prod} branding images, such as the logo displayed in the {prod} dashboard and the link:https://docs.openshift.com/container-platform/{ocp4-ver}/rest_api/console_apis/consolelink-console-openshift-io-v1.html[ConsoleLink] icon. |
Contributor
There was a problem hiding this comment.
Suggested change
| This procedure describes how to customize {prod} branding images, such as the logo displayed in the {prod} dashboard and the link:https://docs.openshift.com/container-platform/{ocp4-ver}/rest_api/console_apis/consolelink-console-openshift-io-v1.html[ConsoleLink] icon. | |
| This procedure describes how to customize {prod} branding images, including the logo shown in the {prod} dashboard, the loader icon and the link:https://docs.openshift.com/container-platform/{ocp4-ver}/rest_api/console_apis/consolelink-console-openshift-io-v1.html[ConsoleLink] icon. |
Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>
Contributor
|
@gtrivedi88 could you take a look please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
This PR renames and expands the existing "Customizing ConsoleLink icon" page into a broader "Customizing branding images" guide that covers all branding images in the
assets/brandingdirectory.Key changes:
customizing-openshift-che-consolelink-icon.adoctocustomizing-openshift-che-branding-images.adocpage-aliasesattribute to preserve the old URL as a redirectloader) in priority order:jpg,jpeg,png,gif,webp,svgnav.adoc) and parent page (configuring-dashboard.adoc) referencesWhat issues does this pull request fix or reference?
fixes https://redhat.atlassian.net/browse/CRW-10433
Specify the version of the product this pull request applies to
DS 3.28.0
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.