Conversation
…files when releasing new version of Cratey-Validator
douglowe
left a comment
douglowe
left a comment
There was a problem hiding this comment.
I've added a couple of comments below. I'd like us to make this build specific to five-safes rocrates, so the naming should reflect this. Also we need to make sure to copy across a tagged release of our five-safes profile, so that we can in future say which exact version of the profile this will test against.
|
|
||
| COPY cratey.py LICENSE /app/ | ||
| COPY app /app/app | ||
| COPY tests/data/rocrate_validator_profiles /app/profiles |
There was a problem hiding this comment.
I didn't copy over all the rocrate validator profiles into the test directory. Also we shouldn't rely on these being up-to-date.
What we need here is to pull a couple of our local rocrate-validator code (use a tagged release, download the zip file, e.g.: https://github.com/eScienceLab/rocrate-validator/releases/tag/five-safes-0.7.3-beta), copy across the five-safes profiles directory (only - don't copy any other profiles), then delete the remaining zip file and code.
|
|
||
| env: | ||
| REGISTRY: ghcr.io | ||
| IMAGE_NAME: ${{ github.repository }}-profiles |
There was a problem hiding this comment.
Can we have a more precise image name here? E.g., fivesafes-profile
There was a problem hiding this comment.
Oh sorry, I forgot to enter an actual name...!
| uses: docker/build-push-action@v6 | ||
| with: | ||
| context: . | ||
| file: ./Dockerfile.profiles |
There was a problem hiding this comment.
This file could be named more clearerly - e.g. Dockerfile.fivesafe-profiles
2 participants
Closes #135
Added dockerfile and workflow to build Docker image with baked-in profiles when releasing new version of Cratey-Validator.