Fix auto-approve workflow check waiting#29
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Thank you for creating this pull request and helping make the project better. We will review / merge it when we are online. |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Jul 3, 2026 11:18a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
|
Thanks for helping make Gmail Alias Toolkit better! |
Motivation
gh pr checks --watch, which can include the approval workflow's own in-progress check and block approval.gh pr review --approve.run: |block which risked invalid YAML parsing.Description
gh pr checks --watchwith an explicit polling loop that callsgh pr checks --json bucket,name,workflowand inspects checkbucketvalues.APPROVAL_WORKFLOW(set togithub.workflow) and exclude that workflow from the wait logic, treat checks withbucketfailorcancelas blocking, and only wait while other checks arepending.printf-based construction so therun: |block remains valid YAML.Testing
ruby -e 'require "psych"; Psych.load_file(".github/workflows/pr-auto-approve.yml"); puts "parsed"'and it succeeded.git diff --checkto ensure no whitespace/syntax issues and it returned clean results.Codex Task