Refactor popup UI foundation#22
Closed
hoangsvit wants to merge 2 commits into
Closed
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Jul 2, 2026 1:57p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cnhelper and lightweight primitives.Description
src/components/ui/includingButton,Input,Card,Tabs,ToggleSwitch,Select,Tooltip,Toast,Badge,StatCard,EmptyState,SectionHeader, acnhelper, and an index barrel for easy imports.entrypoints/popup/components/Button.tsx,Input.tsx,Toggle.tsx) so the rest of the codebase and tests keep the same imports while switching to the new visuals.entrypoints/popup/App.tsxto use the newCard/Button/Toastprimitives and beUI-inspired styling (gradients, rounded-2xl/3xl cards, softshadow-soft, backdrop blur), while preserving all state, storage calls, account switching logic, alias generation/copy flows, and feature behavior.tailwind.config.tsto include./src/**/*.{tsx,ts}for class scanning and added aboxShadow.softtoken used by new components, and kept icons inline to avoid adding additional packages.Testing
yarn compileand the TypeScript build succeeded.yarn testand all unit tests passed after minor styling adjustments to primitives (tests green).yarn buildand the extension bundle was generated successfully (.output/chrome-mv3artifacts present).yarn add clsx tailwind-merge lucide-react motionbut the registry returned403, so a localcnhelper and inline/small svg icons were used as a lightweight workaround to avoid unresolved dependencies and keep the popup size small.Codex Task