feat(dashboard-api): add OIDC admin user bootstrap endpoint#2841
Merged
Conversation
ben-fornefeld
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
PR SummaryMedium Risk Overview Provisioning now ties Reviewed by Cursor Bugbot for commit b8c1c57. Bugbot is set up for automated code reviews on this repo. Configure here. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new admin endpoint /admin/users/bootstrap to bootstrap users authenticated via generic OIDC providers. It adds the corresponding request schema, handler implementation, and database query updates to safely handle concurrent bootstrap requests by resolving identity conflicts and cleaning up orphan user records. Comprehensive unit tests have also been added to verify the routing, OIDC issuer validation, and concurrent bootstrap behavior. No review comments were provided, and there are no critical findings or feedback to report.
❌ 4 Tests Failed:
View the full list of 4 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6222cb0dd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+171
to
+175
| canonicalUserID, err := authTxDB.UpsertPublicIdentity(ctx, authqueries.UpsertPublicIdentityParams{ | ||
| OidcIss: identity.Issuer, | ||
| OidcSub: identity.Subject, | ||
| UserID: candidateUserID, | ||
| }) |
There was a problem hiding this comment.
When AUTH_DB_READ_REPLICA_CONNECTION_STRING points at a lagging replica, this endpoint can return 200 after inserting the (iss, sub) row on the primary, but the next OIDC-authenticated request still resolves identities through authDB.Read in packages/auth/pkg/auth/service.go:77. That makes the bootstrap flow intermittently fail with 401 until replication catches up; the OIDC login path needs to read the newly created identity from primary or otherwise wait/invalidate before reporting success.
Useful? React with 👍 / 👎.
tvi
approved these changes
May 28, 2026
ben-fornefeld
force-pushed
the
ory-bootstrap
branch
5 times, most recently
from
ee666da to
6fef570
Compare
Add POST /admin/users/bootstrap for dashboard Ory sign-in provisioning, with issuer allow-listing, identity upsert concurrency handling, and a route conflict regression test.
ben-fornefeld
force-pushed
the
ory-bootstrap
branch
from
6fef570 to
82a6e8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /admin/users/bootstrapfor OIDC user provisioning (issuer, subject, email, optional name).public.usersandpublic.user_identitiesbefore default team creation, with issuer allow-listing aligned to the Ory profile resolver.POST /admin/users/bootstrapandPOST /admin/users/{userId}/bootstrap.Stack
Stacks on #2840 (Ory user profile provider). Merge #2840 first, then rebase this onto
mainor merge the stack.Dashboard Ory sign-in (
dashboard.full-stackPR #342) depends on this PR landing.