fix(dashboard-api): hide default templates for BYOC teams (clusterID != nil)#2805
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix(dashboard-api): hide default templates for BYOC teams (clusterID != nil)#2805devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
When a team has a clusterID defined (BYOC customer), the /templates/defaults endpoint now returns an empty list instead of showing E2B public templates that aren't available in their cluster. Changes: - Add team auth to /templates/defaults endpoint in OpenAPI spec - Check team.ClusterID in handler; return empty when non-nil - Regenerate api.gen.go Co-Authored-By: ben@e2b.dev <ben@e2b.dev>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
❌ 2 Tests Failed:
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a team has a
clusterIDdefined (BYOC customer), the/templates/defaultsendpoint now returns an empty list instead of showing E2B public templates that aren't available in their cluster.Changes:
Supabase2TeamAuth/AuthProviderTeamAuth) to the/templates/defaultsendpoint in the OpenAPI specGetTemplatesDefaultshandler: ifteam.ClusterID != nil, respond with empty templates listapi.gen.gofrom updated specReview & Testing Checklist for Human
X-Supabase-TeamorX-Team-ID) when calling/templates/defaults. If not, a corresponding dashboard change is needed.AuthProviderBearerAuth+AuthProviderTeamAuthNotes
This addresses the confusion where BYOC customers see public E2B templates in their dashboard that they can't actually use (the API would reject them since templates are scoped by cluster).
Link to Devin session: https://app.devin.ai/sessions/3bab014a95b04fe49f44868d221e484d