Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/charts_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ jobs:
uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: '3.12'
python-version: '3.13'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumPy 1.26.4 incompatible with Python 3.13 in charts

High Severity

The chart_data_extractor project depends on numpy = "^1.26.4" (constrained to <2.0.0), but NumPy 1.26.4 has Requires-Python: <3.13,>=3.9 and is the last 1.x release. Upgrading Python to 3.13 makes it impossible to install numpy within that version constraint, so poetry install will fail. The pyproject.toml constraint needs to be updated to allow NumPy 2.x before switching to Python 3.13.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will upgrade it


- name: Install and configure Poetry
uses: snok/install-poetry@v1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ jobs:
run: pnpm install --frozen-lockfile

- name: Set up Python
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: '3.10'
python-version: '3.13'

- name: Install and configure Poetry
uses: snok/install-poetry@v1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/performance_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ jobs:
uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: '3.12'
python-version: '3.13'

- name: Install and configure Poetry
uses: snok/install-poetry@v1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/python_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ jobs:
uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: '3.12'
python-version: '3.13'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumPy 2.0.2 lacks Python 3.13 support in SDK

High Severity

The python/poetry.lock pins numpy to 2.0.2, which has no cp313 wheels. NumPy 2.1.0 was the first version to add Python 3.13 support (per its release notes). On Python 3.13, Poetry would fall back to building numpy 2.0.2 from source, which is expected to fail because the C code was not updated for Python 3.13 API changes. This breaks python_tests.yml, performance_tests.yml, and lint.yml at poetry install.

Additional Locations (2)

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fine, we can update it at later point


- name: Install and configure Poetry
uses: snok/install-poetry@v1
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,9 @@ jobs:
version: 9.5

- name: Set up Python
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: "3.12"
python-version: "3.13"

- name: Install and configure Poetry
uses: snok/install-poetry@v1
Expand Down Expand Up @@ -285,9 +285,9 @@ jobs:
token: ${{ steps.app-token.outputs.token }}

- name: Set up Python
uses: actions/setup-python@v4
uses: actions/setup-python@v6
with:
python-version: "3.12"
python-version: "3.13"

- name: Install and configure Poetry
uses: snok/install-poetry@v1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release_candidates.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ jobs:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Set up Python
uses: actions/setup-python@v4
uses: actions/setup-python@v6
if: ${{ contains( github.event.pull_request.labels.*.name, 'python-rc') }}
with:
python-version: "3.12"
python-version: "3.13"

- name: Install and configure Poetry
uses: snok/install-poetry@v1
Expand Down
Loading