changed the hard coded version of walk to prune heavy directories like node_modules#90
Open
Ronit Sabhaya (Ronitsabhaya75) wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two related fixes to
sync_ai_rulesto improve hook execution speed and fix target directory resolution.Pruned
os.walkTraversal: Modified thedirnameslist in-place within_ensure_agents_skills_symlinks. Previously, the brute-force traversal would crawl heavy, irrelevant directories (e.g.,.git,node_modules,.venv), causing unnecessary I/O overhead in large monorepos. It now explicitly skips these.Fixed Hardcoded Root Path: Updated the
main()setup which previously hardcodedproject_root = str(Path.cwd()). This caused the script to ignore the--target-dirCLI argument and evaluate the wrong directory context when triggered by the pre-commit framework.