Skip auth for help, version, and completion commands#242
Merged
Conversation
Commands like --help, version, and shell completion generation do not require Dropbox credentials. Previously they would fail if no saved credentials existed, breaking Homebrew's test and shell completion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--help,version,completion, and internal cobra completion helpersdbxcli --helpanddbxcli completion bashpreviously failed without saved credentialsdbxcli --helpin a sandboxed environment)Test plan
dbxcli --helpworks without saved credentialsdbxcli versionworks without saved credentialsdbxcli completion bashworks without saved credentialsdbxcli ls /still requires auth (fails without credentials)go test ./...)