Skip to content

Simpler builds#1038

Merged
YoussefHenna merged 2 commits into
masterfrom
youssef/fix-nativewind-not-working-built-versions
Jun 2, 2026
Merged

Simpler builds#1038
YoussefHenna merged 2 commits into
masterfrom
youssef/fix-nativewind-not-working-built-versions

Conversation

@YoussefHenna
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to simplify the build process across multiple packages (@draftbit/core, maps, native, theme, and ui) by removing the Babel compilation step and pointing the main and react-native entry points directly to the TypeScript source files. However, this introduces critical issues: first, the actual entry files in most of these packages are index.tsx rather than index.ts, which will cause module resolution to fail; second, publishing uncompiled TS/TSX files breaks compatibility with consumer environments that do not transpile node_modules by default. It is recommended to revert these changes or configure tsconfig.json to output compiled JavaScript files to a build directory.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/core/package.json Outdated
Comment thread packages/maps/package.json Outdated
Comment thread packages/native/package.json Outdated
Comment thread packages/theme/package.json
Comment thread packages/ui/package.json Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Published version: @draftbit/ui@54.0.8-6e4257.2

@YoussefHenna YoussefHenna merged commit e4faa3b into master Jun 2, 2026
4 checks passed
@YoussefHenna YoussefHenna deleted the youssef/fix-nativewind-not-working-built-versions branch June 2, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant