fix memory leak of cancelled timeout tasks#3077
Merged
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The issue is already described in #3076. Cancelled/unscheduled tasks were not garbage collected due to strong reference kept in
_pending_tasks. Tasks were only removed from_pending_taskson completion in_poll_once, sounschedule()left them pinned by that strong reference (with their underlying coroutines left unclosed).To confirm that issue exists and is resolved by this PR I am attaching memray screenshots. Leaking version is
kafka-python==3.0.0.Fix Approach:
This PR introduces
_retire_taskto drop the strong reference from_pending_tasksand explicitly closes the coroutine stack on cancellation/shutdown to release the frame's local variables.