Skip to content

[SDPTA-1525] Gha for Playwright#81

Merged
klaukl merged 16 commits intomainfrom
SDPTA-1525-gha-pw
Apr 30, 2026
Merged

[SDPTA-1525] Gha for Playwright#81
klaukl merged 16 commits intomainfrom
SDPTA-1525-gha-pw

Conversation

@klaukl
Copy link
Copy Markdown
Contributor

@klaukl klaukl commented Apr 17, 2026

  • Added Playwright GHA for BE

@klaukl
Copy link
Copy Markdown
Contributor Author

klaukl commented Apr 17, 2026

image Max failures example

@klaukl
Copy link
Copy Markdown
Contributor Author

klaukl commented Apr 17, 2026

Comment thread .github/workflows/test_e2e_be.yml Outdated
@klaukl klaukl changed the title Sdpta 1525 gha pw [SDPTA-1525] gha pw Apr 20, 2026
@klaukl klaukl requested a review from tim-yao April 22, 2026 03:56
Comment thread .github/workflows/test_e2e_be.yml Outdated
Comment thread .github/workflows/test_e2e_be.yml Outdated
Comment thread .github/workflows/test_e2e_be.yml Outdated
tim-yao
tim-yao previously approved these changes Apr 22, 2026
@klaukl klaukl requested a review from tim-yao April 29, 2026 05:00
@klaukl klaukl marked this pull request as ready for review April 29, 2026 05:11
tim-yao
tim-yao previously approved these changes Apr 29, 2026
Copy link
Copy Markdown
Contributor

@tim-yao tim-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klaukl could you please double check to see if there are any workflow inputs that are not used in the jobs?

Comment thread .github/workflows/test_e2e_be.yml Outdated
npm run e2e:backend -- \
--workers=5 \
--max-failures=10
npm run e2e:backend
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include tags.

npm run e2e:backend -- -g "${{ inputs.tags }}"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Re: the workflow inputs not used in jobs:

  • Tags not used yet will implement later I think after cleaning up nightwatch jobs?
  • test_type not an input but used to pass e2e / api / not passed in
  • runner not really used as an input
  • slack notify and slack channel not used as input

@klaukl klaukl changed the title [SDPTA-1525] gha pw [SDPTA-1525] PW GHA BE Apr 30, 2026
@klaukl klaukl changed the title [SDPTA-1525] PW GHA BE [SDPTA-1525] Gha for Playwright Apr 30, 2026
@klaukl klaukl requested a review from tim-yao April 30, 2026 22:55
@klaukl klaukl merged commit 6ee66e4 into main Apr 30, 2026
@klaukl klaukl deleted the SDPTA-1525-gha-pw branch April 30, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants