Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAligns tutorials navigation and pages with proper localization resources and updates the Memorial tutorial sample to use localized text, with corresponding locale entries added/updated. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8023 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 766 766
Lines 34123 34123
Branches 4692 4692
=========================================
Hits 34123 34123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Tutorials documentation/sample experience in the BootstrapBlazor.Server site by moving/adding localization strings used by the Tutorials navigation and pages, and by localizing the new “Memorial” tutorial sample UI.
Changes:
- Moved Tutorials page summary strings into the
TutorialsNavMenulocalization section and removed the oldPages.Tutorialssection (en-US / zh-CN). - Localized
Memorial.razorUI text viaIStringLocalizer<Memorial>and added corresponding locale entries. - Updated
Tutorials.razorandTutorialsNavMenu.razor.csto use the new localization mapping.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/BootstrapBlazor.Server/Locales/zh-CN.json | Adds/moves Tutorials + Memorial localization keys in zh-CN. |
| src/BootstrapBlazor.Server/Locales/en-US.json | Adds/moves Tutorials + Memorial localization keys in en-US. |
| src/BootstrapBlazor.Server/Components/Samples/Tutorials/Memorial.razor | Replaces hardcoded UI strings with localized strings for the Memorial tutorial. |
| src/BootstrapBlazor.Server/Components/Pages/Tutorials.razor | Switches Tutorials page localization to the updated resource group. |
| src/BootstrapBlazor.Server/Components/Layout/TutorialsNavMenu.razor.cs | Simplifies nav menu localization injection and uses the new localizer source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @layout TutorialsLayout | ||
| @page "/tutorials" | ||
| @inject IStringLocalizer<Tutorials> Localizer | ||
| @inject IStringLocalizer<TutorialsNavMenu> Localizer |
Comment on lines
20
to
+22
| [Inject] | ||
| [NotNull] | ||
| private IStringLocalizer<Tutorials>? TutorialsLocalizer { get; set; } | ||
|
|
||
| [Inject] | ||
| [NotNull] | ||
| private IStringLocalizer<Tutorials>? Localizer { get; set; } | ||
| private IStringLocalizer<TutorialsNavMenu>? Localizer { get; set; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #8022
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Localize tutorials navigation and sample content using component-specific resource scopes and update tutorial UI text to be driven by localization resources.
Enhancements:
Documentation: