Update fgMorphSmpOp to canonicalize commutative and compare ops at the start of POST-ORDER#127661
Draft
tannergooding wants to merge 7 commits intodotnet:mainfrom
Draft
Update fgMorphSmpOp to canonicalize commutative and compare ops at the start of POST-ORDER#127661tannergooding wants to merge 7 commits intodotnet:mainfrom
tannergooding wants to merge 7 commits intodotnet:mainfrom
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts CoreCLR JIT morphing to canonicalize operand ordering for commutative operators and comparisons at the start of fgMorphSmpOp post-order processing, improving consistency and enabling post-order optimizations that rely on constants being placed predictably.
Changes:
- Canonicalize commutative and comparison trees in
fgMorphSmpOppost-order by swapping when the left operand is a constant (and swapping relops as needed). - Move the
((a % pow2) ==/!= 0) => (a & (pow2-1) ==/!= 0)pattern optimization from pre-order into theGT_EQ/GT_NEpost-order handling. - Strengthen/debug-guard morphing assumptions by asserting
fgMorphTreeis not invoked during the value-number CSE phase.
tannergooding
force-pushed
the
fgMorphSmpOp
branch
from
c1f0ad2 to
c4471af
Compare
…e start of POST-ORDER
tannergooding
force-pushed
the
fgMorphSmpOp
branch
from
c4471af to
b3541f8
Compare
EgorBo
reviewed
May 1, 2026
EgorBo
reviewed
May 1, 2026
Copilot stopped reviewing on behalf of
tannergooding due to an error
May 2, 2026 00:30
|
|
||
| if (tree->OperIsCompare()) | ||
| { | ||
| tree->gtOper = GenTree::SwapRelop(tree->gtOper); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.