Fix ImmutableHashSet.SetEquals correctness for mismatched comparers#127633
Open
aw0lid wants to merge 1 commit intodotnet:mainfrom
Open
Fix ImmutableHashSet.SetEquals correctness for mismatched comparers#127633aw0lid wants to merge 1 commit intodotnet:mainfrom
aw0lid wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-collections |
pentp
reviewed
May 1, 2026
e3cbd3f to
67de92b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a correctness issue in
SetEqualsintroduced in my previous PR #126309.The
Countcheck was moved inside theComparerequality block. This ensures that when comparers differ, we don't return a false negative and instead fall back to the safe path.Example of the issue fixed:
Changes
if (count != origin.Count)inside theEqualityComparer<IEqualityComparer<T>>.Default.Equalscheck.Related to: #126309