Fix ChaCha20Poly1305 IsSupported test on Azure Linux 4#127618
Merged
vcsjones merged 1 commit intodotnet:mainfrom Apr 30, 2026
Merged
Fix ChaCha20Poly1305 IsSupported test on Azure Linux 4#127618vcsjones merged 1 commit intodotnet:mainfrom
vcsjones merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
bartonjs
approved these changes
Apr 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ChaCha20Poly1305 IsSupported test expectations to reflect that Azure Linux 4 re-enabled the ChaCha20-Poly1305 cipher in its OpenSSL build, while Azure Linux 3 kept it disabled. This keeps the cryptography test suite aligned with the new Azure Linux 4 Helix coverage being added elsewhere.
Changes:
- Adjust
ChaCha20Poly1305Tests.CheckIsSupportedto expect support on Azure Linux 4+ but not on Azure Linux 3. - Add
PlatformDetection.IsAzureLinux4OrHigherto enable version-specific expectations in tests.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography/tests/ChaCha20Poly1305Tests.cs | Updates expected IsSupported behavior for Azure Linux 3 vs 4+. |
| src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs | Adds a new distro/version helper for Azure Linux 4+. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Member
Author
|
/ba-g deadletter, test that was impacted by this change passed on all legs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure Linux 4 re-enabled ChaCha20Poly1305.
The output from
openssl list -cipher-algorithmsincludesChaCha20-Poly1305 @ default.Found in #127613.