JIT: Fix GenTree::IsPow2 functions#127615
Open
BoyBaykiller wants to merge 3 commits intodotnet:mainfrom
Open
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
Author
tannergooding
approved these changes
May 1, 2026
Contributor
Author
|
There was an assert failure in arm codegen which I still had to address |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsIntegralConstUnsignedPow2was passing in sign extended value toisPow2. So it wasn't actually unsigned. For example: 1 << 31 would not be recognized as pow2, because the upper 32 bits were 1. The other 2 were correct technically but I also adjusted them conceptually.