Fix handling of TypedReference returns in call stubs#127603
Open
BrzVlad wants to merge 1 commit intodotnet:mainfrom
Open
Fix handling of TypedReference returns in call stubs#127603BrzVlad wants to merge 1 commit intodotnet:mainfrom
BrzVlad wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CoreCLR’s interpreter/JIT call stub return-type classification to correctly handle methods returning TypedReference, which is a 2-pointer (16-byte on 64-bit) return value, preventing crashes seen in System.Resources.Extensions.BinaryFormat.Tests.
Changes:
- Removes
ELEMENT_TYPE_TYPEDBYREFfrom the “treat like pointer/ref” return-type bucket. - Adds explicit handling for
ELEMENT_TYPE_TYPEDBYREF, intending to classify it as two 8-byte integer returns on 64-bit.
Comment on lines
+2710
to
+2711
| #else | ||
| return ReturnType2I8; |
Comment on lines
+2708
to
+2709
| assert(!"Implement TypedByRef support on 32bit"); | ||
| break; |
Comment on lines
+2708
to
+2709
| assert(!"Implement TypedByRef support on 32bit"); | ||
| break; |
We special case it as consisting of 2 I8s.
BrzVlad
force-pushed
the
fix-clrinterp-typedbyref
branch
from
e14939c to
70cb497
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We special case it as consisting of 2 I8s. Fixes
System.Resources.Extensions.BinaryFormat.Testscrashes when a method returningTypedReferencegets called from interpreter via JIT.