Skip to content

Support reload in ChainedConfigurationSource#125122

Open
martincostello wants to merge 2 commits intodotnet:mainfrom
martincostello:gh-58683
Open

Support reload in ChainedConfigurationSource#125122
martincostello wants to merge 2 commits intodotnet:mainfrom
martincostello:gh-58683

Conversation

@martincostello
Copy link
Member

Add support for reloading configuration to ChainedConfigurationSource.

Fixes #58683.

Add support for reloading configuration to `ChainedConfigurationSource`.

Fixes dotnet#58683.
Copilot AI review requested due to automatic review settings March 3, 2026 14:49
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 3, 2026
@svick
Copy link
Member

svick commented Mar 3, 2026

Thank you for the PR.

I think you should also test the case where the chained configuration is not an IConfigurationRoot, i.e. it's a section of another configuration.

Add a test for when the configuration being reloaded isn't an `IConfigurationRoot`.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Extensions-Configuration community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ChainedConfigurationSource doesn't support reloading manually

3 participants