[NO-MERGE, NO-REVIEW] Experiment: try remove test exclusions#125117
[NO-MERGE, NO-REVIEW] Experiment: try remove test exclusions#125117mrek-msft wants to merge 1 commit intodotnet:mainfrom
Conversation
mrek-msft
added
NO-MERGE
mrek-msft
changed the title
mrek-msft
changed the title
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
There was a problem hiding this comment.
Pull request overview
This PR experimentally removes existing ActiveIssue test exclusions so the previously-skipped tests execute (notably on iOS/tvOS), presumably to observe pipeline behavior.
Changes:
- Re-enable two configuration functional tests by removing
ActiveIssue(60583)on iOS/tvOS. - Re-enable one UserSecrets test by removing
ActiveIssue(60584)on iOS/tvOS.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ArrayTests.cs | Removes the iOS/tvOS ActiveIssue(60583) skip from two [Fact] tests. |
| src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs | Removes the iOS/tvOS ActiveIssue(60584) skip from one [Fact] test. |
| [Fact] | ||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)] | ||
| public void DifferentConfigSources_Merged_KeysAreSorted() |
There was a problem hiding this comment.
These tests were previously disabled on iOS/tvOS via ActiveIssue(60583). Removing the exclusion without a corresponding fix (or confirmation that 60583 is resolved) is likely to reintroduce known failures and make CI unreliable on those platforms. If the issue is still active, keep the attribute; if it’s resolved, consider removing/adjusting all remaining 60583-based skips in related configuration tests so platform coverage is consistent.
| @@ -52,7 +52,6 @@ private void SetSecret(string id, string key, string value) | |||
| } | |||
|
|
|||
| [Fact] | |||
There was a problem hiding this comment.
This test was previously skipped on iOS/tvOS under ActiveIssue(60584), but other tests in this file are still skipped for the same issue. Either the underlying problem is fixed (in which case the remaining 60584 skips should also be removed/updated), or it’s still present and this re-enables a known failing test on those platforms.
| [Fact] | |
| [Fact] | |
| [ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)] |
Just for running pipelines on this experiment.