Skip cross process mutex on OpenBSD#125089
Conversation
|
Tagging subscribers to this area: @agocke, @VSadov |
|
You should also update the condition (and comment) at Then OpenBSD will go down the other implementation path that doesn't use any of those APIs. |
Got it. This would require adding an IsOpenBSD method to the OperatingSystem class though right? I’m happy to do that but I believe that needs to go through API review and approval first correct? Happy to open a PR for that/follow whatever process is needed. |
|
Yes, that would require an API proposal. Though you could make the API internal initially to use it in this PR. |
Contributes to #124911.
OpenBSD does not have:
pthread_mutexattr_setrobustpthread_mutexattr_setpsharedhttps://man.openbsd.org/pthread_mutexattr.3
pthread_mutex_consistenthttps://man.openbsd.org/pthreads.3
I'm assuming that not supporting this means that trying to use this on OpenBSD will result in a PNSE?