Open
Conversation
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
Member
|
Could you update the unsigned integer ones to include the Would probably also be good to cover |
tannergooding
approved these changes
Feb 27, 2026
gewarren
reviewed
Mar 3, 2026
| <remarks>To be added.</remarks> | ||
| <inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" /> | ||
| <exception cref="T:System.DivideByZeroException"> | ||
| <paramref name="right" /> is zero.</exception> |
Contributor
There was a problem hiding this comment.
Suggested change
| <paramref name="right" /> is zero.</exception> | |
| <paramref name="right" /> is 0.</exception> |
@tannergooding Wouldn't 0 be better than zero here?
Member
There was a problem hiding this comment.
I have no preference. There are times where I think zero is more readable and others where I think 0 is instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added exceptions (especially
OverflowException) thatMath.DivRemorInt***.DivRemraise.From dotnet/runtime#124932