[build] Remove WearOS emulator CI lane#11257
Open
jonathanpeppers wants to merge 1 commit intomainfrom
Open
Conversation
The WearOS emulator lane runs 2 test methods on an x86 API 30 wear_square emulator, but neither test exercises WearOS-specific functionality. Remove the lane and the now-unused WearOS category from the test methods. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the dedicated WearOS emulator CI job and drops the now-unused NUnit WearOS category from the two test methods that were only used to route tests into that lane.
Changes:
- Removed the
wear_testsjob frombuild-tools/automation/yaml-templates/stage-msbuild-emulator-tests.yaml. - Removed
[Category ("WearOS")]fromApplicationRunsWithDebuggerAndBreaksinDebuggingTest.cs. - Removed
[Category ("WearOS")]fromDotNetInstallAndRunPreviousSdkinInstallAndRunTests.cs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build-tools/automation/yaml-templates/stage-msbuild-emulator-tests.yaml | Deletes the WearOS emulator CI lane/job and its steps. |
| tests/MSBuildDeviceIntegration/Tests/DebuggingTest.cs | Removes WearOS-only test categorization while keeping the Debugger categorization. |
| tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs | Removes WearOS-only test categorization from the previous-SDK install/run test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #11203 (comment)
Summary
Remove the
wear_testsjob fromstage-msbuild-emulator-tests.yamland thenow-unused
[Category ("WearOS")]attributes from the two test methods thatreferenced it.
Rationale
The WearOS CI lane spins up 2 parallel macOS agents with an x86 API 30
wear_squareemulator (180-minute timeout each) to run just 2 testmethods:
ApplicationRunsWithDebuggerAndBreaksDebuggingTest.csDotNetInstallAndRunPreviousSdkInstallAndRunTests.csNeither test exercises any WearOS API, layout, or behavior. They are standard
app tests that happen to be re-run on a Wear emulator.
These tests already run in the main MSBuild+Emulator lane. The main lane's
filter (
cat != SystemApplication & cat != TimeZoneInfo & cat != Localization)does not exclude the
WearOScategory, so both tests execute there too.What is preserved
WearTests.cs-- 3 MSBuild-level build tests (BasicProject,BundledWearApp,WearProjectJavaBuildFailure) that validate WearOS projectbuilds without needing an emulator.
android-weartemplate -- thedotnet new androidweartemplate and allits localization files are untouched.
XamarinAndroidWearApplicationProject-- test infrastructure class remainsfor use by the build-only tests.
What is removed
wear_testsjob (x86 API 30android-wearemulator, 2 agents)[Category ("WearOS")]fromDebuggingTest.ApplicationRunsWithDebuggerAndBreaks[Category ("WearOS")]fromInstallAndRunTests.DotNetInstallAndRunPreviousSdkCost/benefit
WearTests.cs(3 tests)WearTests.cs(3 tests) -- unchanged