[skills] create a skill for reviewing PRs#292
Merged
jonathanpeppers merged 2 commits intomainfrom Mar 4, 2026
Merged
Conversation
This skill let's you say:
review this PR: #284
Some example code reviews:
* #283 (review)
* #284 (review)
This is built off a combination of previous code reviews, saved in
`docs/CODE_REVIEW_POSTMORTEM.md`, and the review rules in
`references/review-rules.md`.
jonathanpeppers
added
the
copilot
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an android-tools-reviewer GitHub skill to standardize PR reviews for dotnet/android-tools, derived from prior review postmortems and distilled review rules, plus a helper script to validate/submit batched PR review comments via gh api.
Changes:
- Adds
docs/CODE_REVIEW_POSTMORTEM.mdcapturing key review findings from PRs #274–#284. - Adds
references/review-rules.mdas a distilled, actionable checklist for reviews. - Adds the
android-tools-reviewerskill definition (SKILL.md) and asubmit_review.cshelper to validate and post review JSON viagh.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/CODE_REVIEW_POSTMORTEM.md | New postmortem document aggregating review learnings used to inform the skill/rules. |
| .github/skills/android-tools-reviewer/references/review-rules.md | New distilled rule set for automated/manual PR review checks. |
| .github/skills/android-tools-reviewer/SKILL.md | Skill workflow/spec and review JSON template for generating batched 🤖 comments. |
| .github/skills/android-tools-reviewer/scripts/submit_review.cs | CLI helper to validate review JSON and submit it to GitHub via gh api. |
- Fix broken relative link to CODE_REVIEW_POSTMORTEM.md (../docs -> ../../../docs) - Fix misleading error message for 'event' field validation - Add using/dispose on all JsonDocument instances - Drain stdout/stderr concurrently via ReadToEndAsync to prevent deadlock - Compress SKILL.md from 172 to 86 lines while preserving all meaning - Generalize NullProgress rule to null-object pattern for any nullable dependency - Escape postmortem #N references with backticks to prevent GitHub auto-linking Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This skill let's you say:
Some example code reviews:
This is built off a combination of previous code reviews, saved in
docs/CODE_REVIEW_POSTMORTEM.md, and the review rules inreferences/review-rules.md.