Skip to content

Fix some tutorial bits#2575

Open
aquagoose wants to merge 2 commits into
dotnet:mainfrom
aquagoose:fix-tutorial-stuff
Open

Fix some tutorial bits#2575
aquagoose wants to merge 2 commits into
dotnet:mainfrom
aquagoose:fix-tutorial-stuff

Conversation

@aquagoose
Copy link
Copy Markdown
Contributor

@aquagoose aquagoose commented May 1, 2026 •
edited
Loading

Summary of the PR

  • Fixes the Texture tutorial so it uses glTexParameter instead of glTextureParameter
  • Replaces uses of StbImageSharp with ImageSharp
    • This was done because all the other tutorials use ImageSharp, and at the time when I wrote the texture tutorial I decided to replace ImageSharp with StbImageSharp for some reason, but only in the texture tutorial and the existing abstraction tutorial which makes no sense. Also there was a lot of pushback after it was merged after the team noticed it had been replaced, so I'm righting the wrong here.

Related issues, Discord discussions, or proposals

Links go here.

Further Comments

@aquagoose aquagoose requested a review from a team as a code owner May 1, 2026 17:40
Exanite
Exanite approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Exanite Exanite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We can merge once we get a review from Beyley.

I ran the examples locally on Linux and they work fine.
Behavior also matches the main branch.

Comment thread examples/CSharp/OpenGL Tutorials/Tutorial 1.4 - Abstractions/Texture.cs
ImageResult result = ImageResult.FromMemory(File.ReadAllBytes(path), ColorComponents.RedGreenBlueAlpha);

fixed (byte* ptr = result.Data)
//Loading an image using imagesharp.
Copy link
Copy Markdown
Member

@Exanite Exanite May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Ideally we have consistent comment formatting and capitalization here and in the rest of the file since this is part of tutorial code.

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Silk.NET Development Tracker May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Exanite Exanite Exanite approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Silk.NET Development Tracker
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aquagoose @Exanite