Add hardware counter profile#3184
Conversation
|
@dotnet-policy-service agree |
|
It's an interesting approach. But it looks like you can only remap existing |
| @@ -0,0 +1,50 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
If this project is not expected to be executed on CI.
Is it able to define these tests on BenchmarkDotNet.IntegrationTests.ManualRunning project side?
|
|
||
| public class HardwareCounterTests(ITestOutputHelper output) : BenchmarkTestExecutor(output) | ||
| { | ||
| [Fact] |
There was a problem hiding this comment.
This test has ETW namespace.
Is this test works on non-Windows environment?
There was a problem hiding this comment.
I would not expect it to.
In that case, I think it need to replace [Fact] to use [EnvSpecificFact(EnvRequirement.WindowsOnly)].
SUMMARY
It's great that version 1 added counter support, but the expected counter names don't always match what the system provides.
Based on previous attempts (1, 2), providing free input strings provides versatility, but there are also drawbacks:
Therefore, an option with a profile description for extracting the required value sets could solve these problems.
UPD: Added simple test for ETW with custom profile, output result: