chore: Add temporary workaround for ThreadingDiagnoserTests::CompletedWorkItemCountIsAccurate on macos#3101
Open
filzrev wants to merge 2 commits intodotnet:masterfrom
Open
Conversation
filzrev
force-pushed
the
chore-fix-flakey-threading-diagnoser-tests
branch
2 times, most recently
from
65f9b3f to
b85f240
Compare
timcassell
requested changes
Apr 29, 2026
filzrev
force-pushed
the
chore-fix-flakey-threading-diagnoser-tests
branch
2 times, most recently
from
80d7b67 to
be3276b
Compare
filzrev
force-pushed
the
chore-fix-flakey-threading-diagnoser-tests
branch
from
be3276b to
61cae2e
Compare
timcassell
reviewed
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add temporary workaround for #3098
Currently, on macOS environment.
ThreadingDiagnoserTests::CompletedWorkItemCountIsAccuratetest failed randomly.Because some background operation executed during running benchmarks.
At this point, the root cause remains unknown.
So this PR temporary suppress CI failure by reducing assert value of floating point precision.
Note: Temporary modify precision to
0when it's not running with InProcessToolchain.It'll be reverted if it's not works as expected