Light Freshness Edit: ASP.NET - HTTP + Native AOT + Kestrel#37046
Light Freshness Edit: ASP.NET - HTTP + Native AOT + Kestrel#37046GitHubber17 wants to merge 4 commits intodotnet:mainfrom
Conversation
|
@GitHubber17, looks like there are some moniker-versining issues. See the details by clicking the OpenPublishing.Build link for details: |
|
@wadepickett - I did look at the Build report. Please see my notes for you in the top comment. Thanks |
Oh, whoops, sorry, I should have read through that first. |
|
"Wade - In the custom components section, the example code is very similar for both moniker ranges. Good question, thanks. It could not work for both versions. The two code samples are fundamentally different because of the hosting model change:
Going forward, I would discontinue consolidating overlap between versions as a goal, and instead focus only on improving the latest version (which will be carried forward). There was almost always a reason for keeping very near-identical code and instructions separate. Differences can look really minor, but any inaccuracy between versions can render that version's content guidance useless and untrustworthy for development. It would also require significant resources to go back and re-test all the older content and code versions against their respective frameworks and packages for what are editorial rather then technical focused updates. |
|
@GitHubber17 , for this question: It should all look like this I think: "## Access HttpContext from middleware" "## Access HttpContext from SignalR" "## Access HttpContext from gRPC methods" "## Access HttpContext from custom components" |
|
@GitHubber17 Correct there is no /Operation folder in the repo. The instruction in the article is actually technically correct (but really confusing and could be written better); it is referring to a page route, not a file system folder. Good catch, it does need help. Pages/Operation.cshtml is a file in the project, and /Operation is the route (URL) a developer navigates to in the browser when running the app. They're connected by convention, no explicit route registration is needed. The original article text was confusing. When it said "go to the /Operation folder," there's no folder, there's a Pages/Operation.cshtml file that produces a /Operation route. The article meant "navigate to https://localhost:{PORT}/Operation in your browser." How to correct this: I will add the suggestion inline. |
|
Fro this question: For the native-aot.md: Original before the PR: ...
:::moniker range=">= aspnetcore-9.0"
(main content)
:::moniker-end
[!INCLUDE[](~/fundamentals/native-aot/includes/native-aot8.md)]The PR changed it to: monikerRange: '>= aspnetcore-9.0'
(in front matter, inline moniker wrapper removed)
...
[!INCLUDE[](~/fundamentals/native-aot/includes/native-aot8.md)]To fix I think: Remove monikerRange: '>= aspnetcore-9.0' from the front matter and restore the inline :::moniker range=">= aspnetcore-9.0" / :::moniker-end wrapper around the main article content (just before the include). The original article had this structure, and it worked because:
The PR broke this by setting the file-level moniker to >= aspnetcore-9.0, which makes the .NET 8 include's = aspnetcore-8.0 range have no intersection with the file, hence the build warning. |
|
For question: "Tom or Wade - Line 298: Context needed for statement "A parameter on the delegate that isn't bound to the body..." This sentence, original to the file, is an orphaned fragment that lacks context. It reads as a standalone statement but doesn't connect to anything. I didin't write this article and I'm not sure of the author's intent. Here is what I would guess was trying to be said: A parameter on the delegate that isn't bound to the body **doesn't** need to be serializable. For example, a query string parameter can be a rich object type that implements `IParsable<T>`.@tdykstra, that sound right? |
|
For this question related to build warning for Configure endpoints for the ASP.NET Core Kestrel web server Updated include files, ~includes/credentials-warning.md, http-ports.md, make-x509-cert.md The original file on main had: File-level: monikerRange: '>= aspnetcore-5.0' (broad, covers everything) The PR changed the file-level range to '>= aspnetcore-8.0' and removed the inline wrapper, which broke the include. Same thing happened with native-aot.md (file-level narrowed to '>= aspnetcore-9.0', breaking the .NET 8 include). To fix I, I think: |
|
In endpoint.md: For this link on line 129: This resolves fine at the moment when I click on the link in build. Maybe there was a review build issue at the moment when you happen tobe checking it last as a guess. |

This PR contains light freshness updates to the following articles:
[ Additional note from Wade: I updated the questions to address Tom, in addition to myself, since this is Tom's content. ]
Access HttpContext in ASP.NET Core
moniker range >= 6.0,but article descriptions for both ranges say SignalR and gRPC are supported.
Should the two sections be visible for both moniker ranges?
Could the example for the
>=6.0range work for both article versions?Make HTTP requests using IHttpClientFactory in ASP.NET Core
moniker range >= 6.0only; Otherwise, updated for Acrolinx-[Answered by Wade below] Tom or Wade - Line 223: I found no "/Operation" (or similar) folder in the GH repo per the instruction
"In the HttpRequestsSample download, go to the /Operation folder..."
ASP.NET Core support for Native AOT
-[Answered by Wade in discusison below] Tom or Wade - Line 298: Context needed for statement "A parameter on the delegate that isn't bound to the body..."
Configure endpoints for the ASP.NET Core Kestrel web server
<xref>link syntax for broken link, here is the URL<xref:Microsoft.AspNetCore.Server.Kestrel.KestrelConfigurationLoader.Endpoint...
For details, see ADO request 568764.
Internal previews