debt(dwr): replacing PermissionAjax with rest endpoint#34799
Open
debt(dwr): replacing PermissionAjax with rest endpoint#34799
Conversation
…ndpoint
Adds 31 new integration tests covering the previously untested endpoints:
GET /{assetId}, PUT /role/{roleId}/asset/{assetId}, PUT /{assetId}/_individualpermission,
GET /{assetId}/_permissionable, GET /_bypermissiontype, and GET /_bycontent.
Includes security boundary, pagination, roundtrip, and error case coverage.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
- Add Category to AssetPermissionHelper.resolveAsset() chain so category inodes are recognized as permissionable assets - Add inheritedFromType/Path/Id fields to RolePermissionView so the "Getting permissions from parent:" label renders correctly - Guard initPermission() in view_categories.jsp against undefined asset ID Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… issue-34797-dwr-to-rest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompt log: https://gist.github.com/wezell/c4b5f7f20e780e9ebe7f35a68c954ebc
Summary
PermissionAjaxDWR calls with a new REST endpoint (/api/v1/permissions)fetch()calls against the new JAX-RS resourcePermissionAjaxand several other unused DWR classes (HostAjax,InodeAjax,CategoryAjax,PermissionableObjectDWR)Changes
PermissionResource.java— REST endpoint for permission operations (get permissionable, get permissions, save permissions, reset permissions)PermissionableObjectView.java,AssetPermissionHelperenhancementsPermissionAjaxDWR to REST fetch callsdwr.xml— removed unused DWR class mappingsTest Plan
Ref: #34797
🤖 Generated with Claude Code