vendor: github.com/docker/model-runner/cmd/cli v1.0.12#24149
vendor: github.com/docker/model-runner/cmd/cli v1.0.12#24149doringeman wants to merge 2 commits intodocker:mainfrom
Conversation
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
area/release
doringeman
changed the title
See changes in docker/model-runner@cmd/cli/v1.0.3...cmd/cli/v1.0.12. Signed-off-by: Dorin Geman <dorin.geman@docker.com>
| ARG ALPINE_VERSION=3.21 | ||
| ARG GO_VERSION=1.25 | ||
| ARG ALPINE_VERSION=3.23 | ||
| ARG GO_VERSION=1.25.6 |
There was a problem hiding this comment.
Fine to update the directive in go.mod but I don't think this is necessary - we only point to minor versions, not patch.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Documentation Review - PR #24149
Summary
This PR properly updates the vendored auto-generated Docker Model Runner CLI documentation from v1.0.3 to v1.0.12. The changes correctly reflect the upstream updates from github.com/docker/model-runner.
Vendor Update Verification ✅
- New commands added:
launch,search,show,skills - New options for TLS support, proxy certificates, and various runtime configurations
- Updates to existing command documentation and usage patterns
- All changes appear consistent with the upstream source
Documentation Clarity Notes
While the vendor update is correct, I've identified a few areas where the upstream documentation could be clearer for end users. These cannot be fixed in this PR since the content is auto-generated, but may be worth noting for potential upstream contributions or supplementary documentation:
- The
runtime-flagsoption description could benefit from examples - The
modeoption values could use brief explanations of each mode's purpose - The
mmproj(multimodal projector) feature assumes prior knowledge
These are minor clarity issues in the upstream documentation, not problems with this vendor update.
Recommendation
✅ Approve vendor update - The changes correctly reflect the upstream v1.0.12 release.
| swarm: false | ||
| - option: runtime-flags | ||
| value_type: string | ||
| description: raw runtime flags to pass to the inference engine |
There was a problem hiding this comment.
Documentation Clarity (Upstream)
The description "raw runtime flags to pass to the inference engine" could be clearer with examples of valid flags and which backends support specific flags. This is an upstream documentation issue, not something that can be fixed in this vendored update.
Consider filing an issue upstream at github.com/docker/model-runner to improve this documentation.
| - option: mode | ||
| value_type: string | ||
| description: | | ||
| backend operation mode (completion, embedding, reranking, image-generation) |
There was a problem hiding this comment.
Documentation Clarity (Upstream)
The mode option lists values "completion, embedding, reranking, image-generation" but doesn't explain what each mode does or when to use them. Users unfamiliar with these backend concepts may need more context.
This is auto-generated content from upstream. Consider supplementary documentation or an upstream contribution to clarify these modes.
| swarm: false | ||
| - option: mmproj | ||
| value_type: string | ||
| description: absolute path to multimodal projector file |
There was a problem hiding this comment.
Documentation Clarity (Upstream)
The mmproj option ("absolute path to multimodal projector file") assumes prior knowledge of what a multimodal projector is and when it's needed. Users new to multimodal models may need more guidance.
This is auto-generated content. Consider adding supplementary documentation explaining multimodal projectors or contributing upstream improvements.
| module github.com/docker/docs | ||
|
|
||
| go 1.25.0 | ||
| go 1.25.6 |
There was a problem hiding this comment.
FWIW; we should not bump patch versions in go.mod in our modules (if we control it); ideally even remove the .patch from go.mod; see
4 participants
Description
Updated Go to 1.25.6 for https://github.com/docker/model-runner/blob/main/cmd/cli/go.mod.
Update model-cli docs for Docker Model Runner.
See changes in docker/model-runner@cmd/cli/v1.0.3...cmd/cli/v1.0.12.
Reviews